| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | pgman(at)candle(dot)pha(dot)pa(dot)us |
| Cc: | pgsql-committers(at)postgresql(dot)org, kleptog(at)svana(dot)org |
| Subject: | Re: pgsql: Allow psql multi-line column values to align |
| Date: | 2006-02-10 07:25:08 |
| Message-ID: | Pine.BSO.4.61.0602100151570.23655@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-patches |
On Thu, 9 Feb 2006, Bruce Momjian wrote:
> Log Message:
> -----------
> Allow psql multi-line column values to align in the proper columns
>
There is a problem with this on AIX.
http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=asp&dt=2006-02-10%2006:23:00
For tables that have no columns AIX thinks it has an out of memory error.
src/bin/psql/print.c:pg_local_calloc bails out if calloc returns NULL. I
believe AIX is returning NULL for calloc with a count of zero. Efforts
are made not to call pg_local_calloc with a count of zero, but one place
is missed, the attached patch fixes that.
Additionally there are a whole lot of of signedness warnings introduced
which I've attached.
Kris Jurka
| Attachment | Content-Type | Size |
|---|---|---|
| calloczero.patch | text/plain | 985 bytes |
| signwarnings.txt | text/plain | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Teodor Sigaev | 2006-02-10 11:18:40 | pgsql: renew output of regression test accordingly to |
| Previous Message | Kris Jurka | 2006-02-10 05:44:29 | Re: pgsql: Allow psql multi-line column values to align |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ITAGAKI Takahiro | 2006-02-10 09:50:15 | ignore_killed_tuples is always true |
| Previous Message | Kris Jurka | 2006-02-10 05:44:29 | Re: pgsql: Allow psql multi-line column values to align |