pg_dump --clean w/ <= 7.2 server

From: Kris Jurka <books(at)ejurka(dot)com>
To: pgsql-patches(at)postgresql(dot)org
Subject: pg_dump --clean w/ <= 7.2 server
Date: 2004-06-24 12:27:38
Message-ID: Pine.BSO.4.56.0406240722080.3872@leary.csoft.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


When running pg_dump --clean against a server that doesn't have schemas
the namespace is blank and ends up producing a dump full off things like:

DROP TABLE "".tab;

The attached patch only includes a schema if one exists. There are
numerous comments about the DROPs needing to be fully qualified to avoid
conflicting with pg_catalog, but this should be mostly safe because it
would require a user defined object to be present in a later server
version with the same name, and it is difficult to impossible to drop
system objects anyway.

Kris Jurka

Attachment Content-Type Size
dumpclean.patch text/plain 14.7 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Christopher Kings-Lynne 2004-06-24 13:58:22 Re: pg_dump --clean w/ <= 7.2 server
Previous Message Bruce Momjian 2004-06-24 11:00:59 Re: [PATCHES] Configuration patch