Re: BufferSync() & FlushRelationBuffers() conflict

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: Vadim Mikheev <vmikheev(at)sectorbase(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BufferSync() & FlushRelationBuffers() conflict
Date: 2001-03-21 19:04:54
Message-ID: Pine.BSF.4.33.0103211504320.33158-100000@mobile.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Tom, since you appear to be able to recreate the bug, can you comment on
this, as to whether we are okay now?

On Wed, 21 Mar 2001, Vadim Mikheev wrote:

> Just committed changes in bufmgr.c
> Regress tests passed but need more specific tests,
> as usually. Descr as in CVS:
>
> > Check bufHdr->cntxDirty and call StartBufferIO in BufferSync()
> > *before* acquiring shlock on buffer context. This way we should be
> > protected against conflicts with FlushRelationBuffers.
> > (Seems we never do excl lock and then StartBufferIO for the same
> > buffer, so there should be no deadlock here, - but we'd better
> > check this very soon).
>
> Vadim
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
>

Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 2001-03-21 19:17:44 Re: [HACKERS] Patch application
Previous Message Peter Eisentraut 2001-03-21 18:35:00 Re: RPM building (was regression on RedHat)