From: | The Hermit Hacker <scrappy(at)hub(dot)org> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch application |
Date: | 2001-03-19 19:50:56 |
Message-ID: | Pine.BSF.4.33.0103191550440.33158-100000@mobile.hub.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-jdbc pgsql-odbc |
The below basically summarizes my opinion quite well ...
On Mon, 19 Mar 2001, Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I think it is time to start giving people official responsibility for
> > certain areas of the code.
>
> This strikes me as overly formalistic, and more likely to lead to
> arteriosclerosis than any improvement in code quality. Particularly
> with a breakdown such as you have proposed, which would likely mean
> asking multiple people to approve any given patch.
>
> I think the procedural error in this past weekend's contrib mess was
> simply that you didn't pay attention to the fact that Oleg's patch was
> based on an out-of-date copy of the contrib module. You should have
> either merged the changes or bounced it back to Oleg for him to do so.
>
> Insisting on CVS $Header$ or $Id$ markers in all code files might help
> to detect this kind of error --- but nothing will help if you are
> willing to overwrite other people's changes simply because you didn't
> recall the reason for them at the moment.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
>
Marc G. Fournier ICQ#7615664 IRC Nick: Scrappy
Systems Administrator @ hub.org
primary: scrappy(at)hub(dot)org secondary: scrappy(at){freebsd|postgresql}.org
From | Date | Subject | |
---|---|---|---|
Next Message | Larry Rosenman | 2001-03-19 19:51:21 | Re: ODBC/FreeBSD/LinuxEmulation/RPM? |
Previous Message | Alfred Perlstein | 2001-03-19 19:44:02 | Re: ODBC/FreeBSD/LinuxEmulation/RPM? |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-03-19 20:39:24 | Re: Patch application |
Previous Message | Tom Lane | 2001-03-19 19:42:55 | Re: Patch application |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2001-03-19 20:39:24 | Re: Patch application |
Previous Message | Tom Lane | 2001-03-19 19:42:55 | Re: Patch application |