| From: | The Hermit Hacker <scrappy(at)hub(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Matthew Kirkwood <matthew(at)hairy(dot)beasts(dot)org>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Small xlog.c cleanup |
| Date: | 2001-02-27 19:10:07 |
| Message-ID: | Pine.BSF.4.33.0102271509340.354-100000@mobile.hub.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Tue, 27 Feb 2001, Tom Lane wrote:
> The Hermit Hacker <scrappy(at)hub(dot)org> writes:
> > He's moved the "static globals" from around line 286 of
> > src/backend/access/transam/xlog.c:
> > to be static locals inside of function ReadRecord around line 1216 in the
> > same file:
>
> This is not usual coding practice in Postgres, so far as I've noticed.
>
> I prefer to avoid static locals because the fact that they *are* static
> is easily missed. In particular it's way too easy to misread the
> initialization as something that happens on every entry to the function,
> rather than only once. So my opinion is that this change is bad style.
Oops, don't take my response to Bruce as validation, only explanation of
what he was accomplishing, which Bruce appeared to indicate he didn't
understand ...
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2001-02-27 20:55:21 | Re: Small xlog.c cleanup |
| Previous Message | Tom Lane | 2001-02-27 18:38:38 | Re: Small xlog.c cleanup |