Re: [PATCHES] Patch for JDBC timestamp problems

From: The Hermit Hacker <scrappy(at)hub(dot)org>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: <lockhart(at)fourpalms(dot)org>, Barry Lind <barry(at)xythos(dot)com>, <pgsql-patches(at)postgresql(dot)org>, <pgsql-interfaces(at)postgresql(dot)org>, <mcannon(at)internet(dot)com>
Subject: Re: [PATCHES] Patch for JDBC timestamp problems
Date: 2001-01-13 18:46:11
Message-ID: Pine.BSF.4.31.0101131445200.21628-100000@thelab.hub.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-interfaces pgsql-jdbc pgsql-patches

On Sat, 13 Jan 2001, Bruce Momjian wrote:

> > > > I'm confused, as usual. How does forcing the client time zone to GMT fix
> > > > the problem of mismatching client and server time zones? istm that you
> > > > still have a problem if the server is not on GMT.
> > > No idea. When it fixed someone's problem, I was excited.
> >
> > Well, afaict it might have broken most other people, so is not a big
> > win.
>
> That bad, huh? The reason I posted the patch in the email is because I
> don't understand Java and wanted to make sure other people reviewed it,
> especially because we are in beta.

review is *before* you commit, not afterwards ... whether in beta period
or not ...

> It dealt with date/time stuff, which made it double-complex. I am ready
> to yank it if someone gives the word.

consider it given ... and please refrain from letting your "excitement"
impair your judgement in future patch dealings ... review *before*, not
after ...

In response to

Browse pgsql-interfaces by date

  From Date Subject
Next Message Bruce Momjian 2001-01-13 18:53:17 Re: [PATCHES] Patch for JDBC timestamp problems
Previous Message The Hermit Hacker 2001-01-13 18:45:07 Re: [PATCHES] Patch for JDBC timestamp problems

Browse pgsql-jdbc by date

  From Date Subject
Next Message Barry Lind 2001-01-13 21:41:57 Re: [PATCHES] Patch for JDBC timestamp problems
Previous Message The Hermit Hacker 2001-01-13 18:45:07 Re: [PATCHES] Patch for JDBC timestamp problems

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2001-01-13 18:53:17 Re: [PATCHES] Patch for JDBC timestamp problems
Previous Message The Hermit Hacker 2001-01-13 18:45:07 Re: [PATCHES] Patch for JDBC timestamp problems