| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: bogus: logical replication rows/cols combinations |
| Date: | 2022-05-17 03:25:29 |
| Message-ID: | OSZPR01MB6310F32344884F9C12F45071FDCE9@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 16, 2022 8:34 PM houzj(dot)fnst(at)fujitsu(dot)com <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Attach the new version patch.
>
Thanks for your patch. Here are some comments:
1. (0001 patch)
/*
* Returns Oids of tables in a publication.
*/
Datum
pg_get_publication_tables(PG_FUNCTION_ARGS)
Should we modify the comment of pg_get_publication_tables() to "Returns
information of tables in a publication"?
2. (0002 patch)
+ * Note that we don't support the case where column list is different for
+ * the same table when combining publications. But we still need to check
+ * all the given publication-table mappings and report an error if any
+ * publications have different column list.
*
* Multiple publications might have multiple column lists for this
* relation.
I think it would be better if we swap the order of these two paragraphs.
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-05-17 03:26:21 | Re: bogus: logical replication rows/cols combinations |
| Previous Message | Peter Smith | 2022-05-17 02:04:57 | Re: Skipping schema changes in publication |