| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Force streaming every change in logical decoding |
| Date: | 2022-12-21 13:17:18 |
| Message-ID: | OSZPR01MB6310AE2B5AEA3DFB5D4B4F06FDEB9@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 21, 2022 4:05 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Here are some review comments for patch v2.
>
> Since the GUC is still under design maybe these comments can be
> ignored for now, but I guess similar comments will apply in future
> anyhow (just with some name changes).
>
Thanks for your comments.
> ======
>
> 3. More docs.
>
> It might be helpful if this developer option is referenced also on the
> page "31.10.1 Logical Replication > Configuration Settings >
> Publishers" [1]
>
The new added GUC is developer option, and it seems that most developer options
are not referenced on other pages. So, I am not sure if we need to add this to
other docs.
Other comments are fixed [1]. (Some of them are ignored because of the new
design.)
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-12-21 13:54:44 | Re: Force streaming every change in logical decoding |
| Previous Message | shiy.fnst@fujitsu.com | 2022-12-21 13:14:09 | RE: Force streaming every change in logical decoding |