| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Fix pg_publication_tables to exclude generated columns |
| Date: | 2023-01-09 11:59:11 |
| Message-ID: | OSZPR01MB631091CCBC56F195B1B9ACB0FDFE9@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
I noticed that there is a problem about system view pg_publication_tables when
looking into [1]. The column "attnames" contains generated columns when no
column list is specified, but generated columns shouldn't be included because
they are not replicated (see send_relation_and_attrs()).
I think one way to fix it is to modify pg_publication_tables query to exclude
generated columns. But in this way, we need to bump catalog version when fixing
it in back-branch. Another way is to modify function
pg_get_publication_tables()'s return value to contain all supported columns if
no column list is specified, and we don't need to change system view.
Attach the patch for HEAD, and we can ignore the changes of the system view in
PG15.
Regards,
Shi yu
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0002-Test-for-column-list-check-in-tablesync.patch | application/octet-stream | 1.8 KB |
| v1-0001-Modify-pg_get_publication_tables-to-show-all-colu.patch | application/octet-stream | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-01-09 12:03:34 | Re: [PATCH] random_normal function |
| Previous Message | Nitin Jadhav | 2023-01-09 11:38:42 | Re: Split index and table statistics into different types of stats |