| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Subject: | RE: Handle infinite recursion in logical replication setup |
| Date: | 2022-07-26 08:05:05 |
| Message-ID: | OSZPR01MB63108E9DAB621872B6CADC39FD949@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Jul 24, 2022 1:28 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Added a note for the same and referred it to the conflicts section.
>
> Thanks for the comments, the attached v38 patch has the changes for the
> same.
>
Thanks for updating the patch. A comment on the test in 0001 patch.
+# Alter subscription ... refresh publication should fail when a new table is
+# subscribing data from a different publication should fail
+($result, $stdout, $stderr) = $node_A->psql(
+ 'postgres', "
+ ALTER SUBSCRIPTION tap_sub_A2 REFRESH PUBLICATION");
+like(
+ $stderr,
+ qr/ERROR: ( [A-Z0-9]+:)? could not replicate table "public.tab_new"/,
+ "Create subscription with origin and copy_data having replicated table in publisher"
+);
The comment says "should fail" twice, the latter one can be removed.
Besides, "Create subscription with origin and copy_data" should be changed to
"Alter subscription with origin and copy_data" I think.
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-26 08:17:39 | Re: Make name optional in CREATE STATISTICS |
| Previous Message | Dilip Kumar | 2022-07-26 08:01:38 | Re: making relfilenodes 56 bits |