| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Replica Identity check of partition table on subscriber |
| Date: | 2022-06-15 03:22:19 |
| Message-ID: | OSZPR01MB6310757179D431D5480AF6CCFDAD9@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jun 14, 2022 8:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> > v4-0002 looks good btw, except the bitpick about test comment similar
> > to my earlier comment regarding v5-0001:
> >
> > +# Change the column order of table on publisher
> >
> > I think it might be better to say something specific to describe the
> > test intent, like:
> >
> > Test that replication into partitioned target table continues to works
> > correctly when the published table is altered
> >
>
> Okay changed this and slightly modify the comments and commit message.
> I am just attaching the HEAD patches for the first two issues.
>
Thanks for updating the patch.
Attached the new patch set which ran pgindent, and the patches for pg14 and
pg13. (Only the first two patches of the patch set.)
Regards,
Shi yu
| Attachment | Content-Type | Size |
|---|---|---|
| v8-pg14-0002-Fix-data-inconsistency-between-publisher-and-su_patch | application/octet-stream | 4.6 KB |
| v8-pg14-0001-Fix-cache-look-up-failures-while-applying-chang_patch | application/octet-stream | 8.0 KB |
| v8-pg13-0002-Fix-data-inconsistency-between-publisher-and-su_patch | application/octet-stream | 4.6 KB |
| v8-pg13-0001-Fix-cache-look-up-failures-while-applying-chang_patch | application/octet-stream | 8.0 KB |
| v8-0002-Fix-data-inconsistency-between-publisher-and-subs.patch | application/octet-stream | 4.4 KB |
| v8-0001-Fix-cache-look-up-failures-while-applying-changes.patch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | XueJing Zhao | 2022-06-15 03:33:04 | Remove useless param for create_groupingsets_path |
| Previous Message | Amit Langote | 2022-06-15 02:41:40 | Re: Replica Identity check of partition table on subscriber |