Re: Replica Identity check of partition table on subscriber

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: Re: Replica Identity check of partition table on subscriber
Date: 2022-06-15 12:29:46
Message-ID: CAA4eK1LgAa0xocEaQg_dQ2SJvBf4w2mwEsYxU2rZRF1LZ6UXdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 15, 2022 at 8:52 AM shiy(dot)fnst(at)fujitsu(dot)com
<shiy(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tue, Jun 14, 2022 8:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > > v4-0002 looks good btw, except the bitpick about test comment similar
> > > to my earlier comment regarding v5-0001:
> > >
> > > +# Change the column order of table on publisher
> > >
> > > I think it might be better to say something specific to describe the
> > > test intent, like:
> > >
> > > Test that replication into partitioned target table continues to works
> > > correctly when the published table is altered
> > >
> >
> > Okay changed this and slightly modify the comments and commit message.
> > I am just attaching the HEAD patches for the first two issues.
> >
>
> Thanks for updating the patch.
>
> Attached the new patch set which ran pgindent, and the patches for pg14 and
> pg13. (Only the first two patches of the patch set.)
>

I have pushed the first bug-fix patch today.

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Aleksander Alekseev 2022-06-15 12:38:23 Re: [PATCH] Compression dictionaries for JSONB
Previous Message Amit Kapila 2022-06-15 12:12:44 Re: Perform streaming logical transactions by background workers and parallel apply