| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Handle infinite recursion in logical replication setup |
| Date: | 2022-05-19 08:41:54 |
| Message-ID: | OSZPR01MB631032CF0F79B833E5A8CC1BFDD09@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, May 4, 2022 2:47 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for the comments, the attached v13 patch has the changes for the same.
>
Here are some comments on v13-0002 patch.
1)
+ * Throw an error so that the user can take care of the initial data
+ * copying and then create subscription with copy_data off.
Should "with copy_data off" be changed to "with copy_data off or force"?
2)
case ALTER_SUBSCRIPTION_ADD_PUBLICATION:
case ALTER_SUBSCRIPTION_DROP_PUBLICATION:
...
/*
* See ALTER_SUBSCRIPTION_REFRESH for details why this is
* not allowed.
*/
if (sub->twophasestate == LOGICALREP_TWOPHASE_STATE_ENABLED && opts.copy_data)
I think we need some changes here, too. Should it be modified to:
if (sub->twophasestate == LOGICALREP_TWOPHASE_STATE_ENABLED && IS_COPY_DATA_ON_OR_FORCE(opts.copy_data))
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | huangning290@yahoo.com | 2022-05-19 08:59:17 | parallel not working |
| Previous Message | Michael Paquier | 2022-05-19 08:20:23 | Re: Zstandard support for toast compression |