| From: | "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Column Filtering in Logical Replication |
| Date: | 2022-09-05 03:42:40 |
| Message-ID: | OSZPR01MB631004818E8E3D397F8B2CD1FD7F9@OSZPR01MB6310.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 5, 2022 8:28 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> I have rebased the remaining patch (v6-0001 is the same as v5-0002)
>
Thanks for updating the patch. Here are some comments.
1.
+ the <xref linkend="sql-alterpublication"/> will be successful but later
+ the WalSender on the publisher, or the subscriber may throw an error. In
+ this scenario, the user needs to recreate the subscription after adjusting
Should "WalSender" be changed to "walsender"? I saw "walsender" is used in other
places in the documentation.
2.
+test_pub=# CREATE TABLE t1(id int, a text, b text, c text, d text, e text, PRIMARY KEY(id));
+CREATE TABLE
+test_pub=#
+test_pub=# CREATE PUBLICATION p1 FOR TABLE t1 (id, b, a, d);
+CREATE PUBLICATION
+test_pub=#
I think the redundant "test_pub=#" can be removed.
Besides, I tested the examples in the patch, there's no problem.
Regards,
Shi yu
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2022-09-05 04:17:05 | Re: Handle infinite recursion in logical replication setup |
| Previous Message | Thomas Munro | 2022-09-05 02:28:48 | Re: Postmaster self-deadlock due to PLT linkage resolution |