| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Alexander Korotkov' <aekorotkov(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Vitaly Davydov <v(dot)davydov(at)postgrespro(dot)ru>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "tomas(at)vondra(dot)me" <tomas(at)vondra(dot)me>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly |
| Date: | 2025-06-26 03:46:44 |
| Message-ID: | OSCPR01MB14966C00587EEA20AA28718F1F57AA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Alexander,
>
> Good idea. But I think we should associate the "updated" flag
> directly to the fact that one slot (no matter logical or physical)
> changed its last_saved_restart_lsn. See the attached patch. I'm
> going to push it if no objections.
+ /*
+ * Track if we're going to update slot's last_saved_restart_lsn.
+ * We need this to know if we need to recompute the required LSN.
+ */
+ if (s->last_saved_restart_lsn != s->data.restart_lsn)
+ last_saved_restart_lsn_updated = true;
I feel no need to set to true if last_saved_restart_lsn_updated is already true.
Other than that it's OK for me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajit Awekar | 2025-06-26 04:15:31 | Re: Unnecessary scan from non-overlapping range predicates |
| Previous Message | Richard Guo | 2025-06-26 03:38:56 | Re: Virtual generated columns |