| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Two issues with version checks in CREATE SUBSCRIPTION |
| Date: | 2025-12-23 05:55:41 |
| Message-ID: | OSCPR01MB14966BDE9419034B4BE782B27F5B5A@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
Thanks for the patch! They basically look good to me.
> First, in subscriptioncmds.c this check rejects enabling retain_dead_tuples
> when the publisher is running an older version. However, the comparison uses
> 19000 as v19 value. Since server versions are encoded as 190000 for v19,
> this appears to be a typo and allows the option to be enabled unexpectedly
> on pre-v19 publishers. The attached 0001 patch fixes this by correcting
> the version constant.
One idea is to introduce a constant like RETAIN_DEAD_TUPLES_MIN_VERSION_NUM,
which avoids similar typo. Is it overengineering?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2025-12-23 06:11:24 | Re: Proposal: Conflict log history table for Logical Replication |
| Previous Message | shveta malik | 2025-12-23 05:25:08 | Re: Proposal: Conflict log history table for Logical Replication |