| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: pg_createsubscriber --dry-run logging concerns |
| Date: | 2025-10-01 03:09:26 |
| Message-ID: | OSCPR01MB149668DD062C1457FFAA44A28F5E6A@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Peter,
> IMO, it's not good to fool people into thinking something has happened
> when in fact nothing happened at all. I think the logging of this tool
> should be much more explicit wrt when it is/isn't in dry-run mode.
> Perhaps like this:
>
> NORMAL
> pg_log_info("creating publication \"%s\" in database \"%s\"", ...)
>
> DRY-RUN
> pg_log_info("[dry-run] would create publication \"%s\" in database \"%s\"", ...)
Per my understanding, almost all the output must be adjusted based on the mode, right?
I feel it introduces a burden.
Can we solve the issue if we print additional message at the beginning if the
command runs with dry-run mode?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-01 03:40:43 | Re: [PATCH] Add tests for Bitmapset |
| Previous Message | jian he | 2025-10-01 03:04:54 | Re: bug, ALTER TABLE call ATPostAlterTypeCleanup twice for the same relation |