RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Noboru Saito' <noborusai(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Florents Tselai <florents(dot)tselai(at)gmail(dot)com>
Subject: RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date: 2025-06-11 04:48:09
Message-ID: OSCPR01MB1496668F87FB97A0CCB63918CF575A@OSCPR01MB14966.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Saito-san,

> Yes, your understanding is correct. The top-right image was generated
> with the previous patch, and the bottom-right with the v2 patch.
>
> Thank you also for your advice regarding splitting the patch into two parts:
> - 0001: Set both body.start.indent and body.end.indent to 0
> - 0002: Set margin-left and margin-right to 0.25in
>
> I agree that separating the patches will make the review process easier.
> I will prepare and send a patch series using `git format-patch` as you
> suggested.
>
> I have also attached a part of the PDF generated with both 0001 and
> 0002 applied for your reference.

The patch is cleanly created, and +1 for all contents.

Another general suggestion: Please avoid the top-post when you reply. According
to the wikipage [1]:

```
Finally, our community generally does not "top post" in response to mailing list threads (See Wikipedia:
Top Postingfor a definition of top posting, and Top Posting Deprecated for discussion of why we discourage it).
```

And a Japanese article written by Fujii-san is also helpful [2].

[1]: https://wiki.postgresql.org/wiki/Mailing_Lists
[2]: https://www.slideshare.net/slideshow/postgresql-community-development-deim2024-nttdata/266677773#24

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhijie Hou (Fujitsu) 2025-06-11 04:48:12 RE: failover logical replication slots
Previous Message jian he 2025-06-11 04:45:17 Re: Add SPLIT PARTITION/MERGE PARTITIONS commands