| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shawn McCoy <shawn(dot)the(dot)mccoy(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, "drewwcallahan(at)gmail(dot)com" <drewwcallahan(at)gmail(dot)com>, "scott(at)meads(dot)us" <scott(at)meads(dot)us> |
| Subject: | RE: Disabled logical replication origin session causes primary key errors |
| Date: | 2025-04-22 09:06:20 |
| Message-ID: | OSCPR01MB149665D61D6C16D0F4AA66B5BF5BB2@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Dear Sawada-san,
> Thank you for the patch. The changes look reasonable to me. Can we add
> some regression tests for that?
>
Yeah it should be added. I think it is enough to add the first scenario. Done in
100_bugs.pl.
I also ran pgindent/pgperltidy. Because of self-reviewing the version became v4.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v4-HEAD-0001-Fix-oversight-3f28b2f.patch | application/octet-stream | 6.6 KB |
| v4-PG16-17-0001-Fix-oversight-3f28b2f.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2025-04-22 09:36:38 | Re: Disabled logical replication origin session causes primary key errors |
| Previous Message | Amit Kapila | 2025-04-22 02:35:05 | Re: Disabled logical replication origin session causes primary key errors |