| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Michael Paquier' <michael(at)paquier(dot)xyz>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | RE: pg_logical_slot_get_changes waits continously for a partial WAL record spanning across 2 pages |
| Date: | 2025-07-15 09:14:27 |
| Message-ID: | OSCPR01MB149665CAB31B5BB5B9CAF0D8AF557A@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Michael,
> I like the addition of an extra pg_logical_emit_message() in test 046
> anyway, down to v17, in the test 046 for all the branches. Even if
> the reproduction is sporadic, we have seen it pretty quickly in the CI
> and in the buildfarm so it would not go unnoticed for a long time if
> we mess up with this stuff again.
I put pg_logical_emit_message() after injection_points_wakeup(), but your patch
puts it before. I verified even your patch can reproduce the issue, but is there
a reason?
(This is not a comment which must be fixed, I just want to know the reason to study)
> With all that said, I'll move on with this stuff once the embargo for
> v18 beta2 is lifted and the tag is pushed. That should happen in 24h
> or so, I guess.
The provided patches looks good to me.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Kukushkin | 2025-07-15 09:24:35 | Re: Requested WAL segment xxx has already been removed |
| Previous Message | wenhui qiu | 2025-07-15 08:41:56 | Re: Requested WAL segment xxx has already been removed |