From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
---|---|
To: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Subject: | Minor patch; missing comment update in worker.c |
Date: | 2025-06-23 02:52:16 |
Message-ID: | OSCPR01MB1496656725F3951AEE8749EBDF579A@OSCPR01MB14966.jpnprd01.prod.outlook.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dear hackers,
(Adding Amit in CC because he was an original committer)
While reading codes in master, I found the below comment in worker.c.:
```
* We don't allow to toggle two_phase option of a subscription because it can
* lead to an inconsistent replica. Consider, initially, it was on and we have
* received some prepare then we turn it off, now at commit time the server
* will send the entire transaction data along with the commit. With some more
* analysis, we can allow changing this option from off to on but not sure if
* that alone would be useful.
```
But this is not correct anymore, 1462aad2 allows to alter two_phase option.
I was an original author, but I did oversight.
I feel it can be fixed by referring the commit message, attached patch fixed like
that. How do you feel?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-missing-comment-update-in-1462aad2.patch | application/octet-stream | 1.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jingtang Zhang | 2025-06-23 02:58:56 | pg_waldump -R filter |
Previous Message | Robins Tharakan | 2025-06-23 01:46:31 | Re: leafhopper / snakefly failing to build HEAD - GCC bug |