| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Fujii Masao' <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, 'Peter Eisentraut' <peter(at)eisentraut(dot)org> |
| Cc: | "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Missing program_XXX calling in pgbench tests |
| Date: | 2025-06-09 04:48:33 |
| Message-ID: | OSCPR01MB1496610451F5896375B2562E6F56BA@OSCPR01MB14966.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Fujii-san,
> I agree with Peter. I don't think patches 0002 and 0003 are necessary.
>
> As for 0004, it adds tests for the short options -? and -V, which
> duplicate the existing tests for the long options --help and --version.
> I'm not sure it's worth adding tests just to confirm that the short
> and long options behave the same.
Only adding 0004 is not allowed because it can fail due to other commands.
So let's drop them.
I verified 0001 can be applied cleanly for all supported branches. To clarify,
let me attach the 0001 patch again. Please focus on it...
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v3-PG13-HEAD-0001-pgbench-Run-program_XXX-tests-instead-of-its.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Xuneng Zhou | 2025-06-09 04:52:12 | Re: Add new wait event to XactLockTableWait |
| Previous Message | Pavel Stehule | 2025-06-09 04:06:25 | Re: pg_restore - cannot to restore blobs in dictionary format from older pg dumps |