RE: [HACKERS] logical decoding of two-phase transactions

From: "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>
To: 'Peter Smith' <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: RE: [HACKERS] logical decoding of two-phase transactions
Date: 2021-03-06 07:55:44
Message-ID: OSBPR01MB4888636EB9421C930FB39A19ED959@OSBPR01MB4888.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

On Saturday, March 6, 2021 10:49 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> Please find attached the latest patch set v50*

When I read throught the patch set, I found there is a
wierd errmsg in apply_handle_begin_prepare(), which seems a mistake.

File : v50-0003-Add-support-for-apply-at-prepare-time-to-built-i.patch

+ * The gid must not already be prepared.
+ */
+ if (LookupGXact(begin_data.gid, begin_data.end_lsn, begin_data.committime))
+ ereport(ERROR,
+ (errcode(ERRCODE_DUPLICATE_OBJECT),
+ errmsg("transaction?identifier?\"%s\"?is?already?in?use",
+ begin_data.gid)));

Please fix this in a next update.

Best Regards,
Takamichi Osumi

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2021-03-06 08:43:45 Re: Increase value of OUTER_VAR
Previous Message Andrey Borodin 2021-03-06 07:29:14 Re: Different compression methods for FPI