RE: locking [user] catalog tables vs 2pc vs logical rep

From: "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com>
To: 'vignesh C' <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>
Subject: RE: locking [user] catalog tables vs 2pc vs logical rep
Date: 2021-06-14 12:03:00
Message-ID: OSBPR01MB48881128C1116D510E8765CAED319@OSBPR01MB4888.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Friday, June 11, 2021 2:13 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> Thanks for the updated patch:
> Few comments:
> 1) We have used Reordering and Clustering for the same command, we could
> rephrase similarly in both places.
> + <para>
> + Reordering <structname>pg_class</structname> by
> <command>CLUSTER</command>
> + command in a transaction.
> + </para>
>
> + <para>
> + Clustering <structname>pg_trigger</structname> and decoding
> <command>PREPARE
> + TRANSACTION</command>, if any published table have a trigger
> and any
> + operations that will be decoded are conducted.
> + </para>
> + </listitem>
>
> 2) Here user_catalog_table should be user catalog table
> + <para>
> + Executing <command>TRUNCATE</command> on
> user_catalog_table
> in a transaction.
> + </para>
Thanks for your review.

Attached the patch-set that addressed those two comments.
I also fixed the commit message a bit in the 2PC specific patch to HEAD.
No other changes.

Please check.

Best Regards,
Takamichi Osumi

Attachment Content-Type Size
HEAD_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB
HEAD_with_2PC_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 2.5 KB
PG10_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB
PG11_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB
PG12_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB
PG13_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB
PG96_deadlock_documentation_of_logical_decoding_v06.patch application/octet-stream 4.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-06-14 12:03:49 Re: Fdw batch insert error out when set batch_size > 65535
Previous Message Andrew Dunstan 2021-06-14 11:33:39 Fwd: BUG #17056: Segmentation fault on altering the type of the foreign table column with a default