| From: | "imai(dot)yoshikazu(at)fujitsu(dot)com" <imai(dot)yoshikazu(at)fujitsu(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "yotsunaga(dot)naoki(at)fujitsu(dot)com" <yotsunaga(dot)naoki(at)fujitsu(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Phil Florent <philflorent(at)hotmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [Proposal] Add accumulated statistics |
| Date: | 2019-12-19 06:05:22 |
| Message-ID: | OSBPR01MB4616EE89C3F469E44B3E6B6394520@OSBPR01MB4616.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Dec 1, 2019 at 1:10 AM, Michael Paquier wrote:
> On Wed, Oct 30, 2019 at 05:55:28AM +0000, imai(dot)yoshikazu(at)fujitsu(dot)com wrote:
> > And here is the patch which counts the wait event and measuring the wait event time. It is currently like POC and has several things to be improved.
>
> Please note the patch tester complains about the latest patch:
> pgstatfuncs.c: In function ‘pg_stat_get_waitaccum’:
> pgstatfuncs.c:2018:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
> Datum values[PG_STAT_GET_WAITACCUM_COLS];
>
> I am moving it to next CF, marking it as waiting on author.
Sorry for late reply.
Unfortunately, I couldn't get your original mail even if I used "Resend email"
on pgsql-hackers archive, that I reply to my old mail.
I attach the patch I solved the warning.
--
Yoshikazu Imai
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Adding-the-pg_stat_waitaccum-view-which-shows-counts-v3.patch | application/octet-stream | 30.6 KB |
| 0002-POC-Changed-measuring-method-of-wait-event-timed-fro-v3.patch | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-12-19 06:29:29 | Re: logical decoding : exceeded maxAllocatedDescs for .spill files |
| Previous Message | Mahendra Singh | 2019-12-19 05:56:14 | Re: [HACKERS] Block level parallel vacuum |