| From: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Refactor ECPGconnect and allow IPv6 connection |
| Date: | 2021-02-24 06:33:12 |
| Message-ID: | OSBPR01MB3157D67E2F83BB70E1354E74F59F9@OSBPR01MB3157.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Wang,
Thank you for giving comments!
I forgot to write that parse functions imitates libpq's functios,
but you understood that immediately. Genius!
> So, I think parse_options() is not need to be refactored.
OK.
> I think we can use the message as same as the message in fe-connect.c:
> > libpq_gettext("end of string reached when looking for matching \"]\" in IPv6 host address in URI: \"%s\"\n"),
The word "URI" is not used in the ECPG docs and source comments, so I removed.
If we want to add, we should define the "URI" in the ECPG context.
> Maybe we can add the expected character, like (expected ':', '/', '?' or ',')
Fixed, but I think ',' is not allowed in the ECPG.
And I did not add URI because the above reason.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-refactor_ecpgconnect.patch | application/octet-stream | 16.8 KB |
| v2-0002-allow-IPv6.patch | application/octet-stream | 7.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-02-24 07:09:48 | Re: Is Recovery actually paused? |
| Previous Message | Thomas Munro | 2021-02-24 06:19:00 | Re: Asynchronous and "direct" IO support for PostgreSQL. |