| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Subject: | RE: Disallow changing slot's failover option in transaction block |
| Date: | 2024-04-19 02:54:17 |
| Message-ID: | OSBPR01MB2552A17F786761759ED149A9F50D2@OSBPR01MB2552.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hou,
Thanks for updating the patch! Let me confirm the content.
In your patch, the pg_dump.c was updated. IIUC the main reason was that
pg_restore executes some queries as single transactions so that ALTER
SUBSCRIPTION cannot be done, right?
Also, failover was synchronized only when we were in the upgrade mode, but
your patch seems to remove the condition. Can you clarify the reason?
Other than that, the patch LGTM.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
https://www.fujitsu.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2024-04-19 03:03:46 | Re: ECPG cleanup and fix for clang compile-time problem |
| Previous Message | Tom Lane | 2024-04-19 02:24:11 | Re: Speed up clean meson builds by ~25% |