| From: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
|---|---|
| To: | 'Dilip Kumar' <dilipbalaut(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Fix of fake unlogged LSN initialization |
| Date: | 2019-10-25 02:11:55 |
| Message-ID: | OSBPR01MB2503FF946B01198523EBF6F9FE650@OSBPR01MB2503.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
> I have noticed that in StartupXlog also we reset it with 1, you might
> want to fix that as well?
>
> StartupXLOG
> {
> ...
> /*
> * Initialize unlogged LSN. On a clean shutdown, it's restored from the
> * control file. On recovery, all unlogged relations are blown away, so
> * the unlogged LSN counter can be reset too.
> */
> if (ControlFile->state == DB_SHUTDOWNED)
> XLogCtl->unloggedLSN = ControlFile->unloggedLSN;
> else
> XLogCtl->unloggedLSN = 1;
>
Thanks for taking a look. I'm afraid my patch includes the fix for this part.
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-10-25 02:41:45 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Amit Kapila | 2019-10-25 02:07:13 | Re: [HACKERS] Block level parallel vacuum |