| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Chao Li' <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: pg_createsubscriber: allow duplicate subscription names |
| Date: | 2026-08-06 07:09:41 |
| Message-ID: | OS9PR01MB12149D2214320C1ABABBCEEB3F5D22@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Chao,
Thanks for working on it. I checked your patch and briefly looks good.
```
+ if (duplicate_sub_name && num_replslots == 0)
+ {
+ pg_log_error("duplicate subscription names require distinct replication slot names");
+ pg_log_error_detail("When replication slot names are not specified, subscription names are used, but replication slot names must be unique within a cluster.");
+ pg_log_error_hint("Specify a unique --replication-slot name for each database.");
+ exit(1);
+ }
```
Not sure pg_log_error_detail() is helpful here. Can we remove?
Also I feel we do not have to clarify "distinct/unique" for replication slot names,
it has already been described other lines.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2026-08-06 07:09:44 | Credits For v19 |
| Previous Message | Bharath Rupireddy | 2026-08-06 07:03:38 | Re: Add a hook for handling logical decoding messages on subscribers. |