| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Smith' <smithpb2250(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Skipping schema changes in publication |
| Date: | 2026-03-31 03:54:37 |
| Message-ID: | OS9PR01MB12149CC87E864D982B5619365F553A@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Peter,
> ======
> src/bin/psql/tab-complete.in.c
>
> 4.
> - COMPLETE_WITH("EXCEPT TABLE (");
> + COMPLETE_WITH("EXCEPT ( TABLE");
>
> (this is in several places in ALTER and CREATE)
>
> In v3 the space in "( TABLE" was changed to "(TABLE", but now in v4
> the space is back again. AFAICT the v3 change was in response to
> review [1] (comment #2). Was it reverted deliberately?
I think it's proper to have the blank before/after the parentheses. See the
existing example.
```
/* ALTER TABLE <name> SPLIT PARTITION <name> */
else if (Matches("ALTER", "TABLE", MatchAny, "SPLIT", "PARTITION", MatchAny))
COMPLETE_WITH("INTO ( PARTITION");
```
Also, if we type till `CREATE PUBLICATION pub WITH` and type tab several times,
the suggested string is something like below:
```
CREATE PUBLICATION pub WITH ( PUBLISH
```
It means normally the blank exists in between the term.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-03-31 03:55:31 | Re: Skipping schema changes in publication |
| Previous Message | Richard Guo | 2026-03-31 03:41:09 | Fix HAVING-to-WHERE pushdown with nondeterministic collations |