| From: | Xuneng Zhou <xunengzhou(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Reject WAIT FOR earlier in transaction-snapshot mode |
| Date: | 2026-09-10 11:02:22 |
| Message-ID: | CABPTF7UjvPpa7fLCg8jC5Dnh-L1dwkV+ecssYGps1VqwpBejvw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Álvaro,
On Thu, Sep 10, 2026 at 6:21 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> Hi,
>
> Not critically important but note that the PopActiveSnapshot and
> InvalidateCatalogSnapshot call and the comment about "giving up if there
> is still an active or registered snapshot" have a close relationship; I
> think it would make sense to keep them together. I would add your new
> test-and-ereport just before the PopActiveSnapshot() call, to avoid
> breaking that.
Good catch. +1 for doing that.
--
Regards,
Xuneng Zhou
HighGo Software Co., Ltd.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-09-10 11:06:27 | RE: Review items for EXCEPT TABLE publication |
| Previous Message | Siddharth Kothari | 2026-09-10 11:01:10 | Re: [PATCH] Add RetrieveInstrumentation hook for CustomScan providers |