RE: Improve docs syntax checking and enable it in the meson build

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Nazir Bilal Yavuz' <byavuz81(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: RE: Improve docs syntax checking and enable it in the meson build
Date: 2026-02-16 10:49:09
Message-ID: OS9PR01MB12149A36ED46A840413CF56E7F56CA@OS9PR01MB12149.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear Nazir,

> I see your point but the suggested change actually doesn't affect C
> files' compilation. They are still built although you make this
> change, AFAIK this is how meson build works.

Did you say that C files would be anyway built even after applying my change?
I don't think so - I have verified that only needed documents were built with
the `meson test --suite doc` command after I modified meson.build.

```
$ ninja clean
[2/2] Cleaning
Cleaning... 8 files.
$ meson test --suite doc
ninja: Entering directory `/home/hayato/builddir'
[8/8] Generating doc/src/sgml/postgres-full.xml with a custom command // only 8 files are generated
1/1 postgresql:doc / doc/sgml_syntax_check OK 0.38s

Ok: 1
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Full log written to /home/hayato/builddir/meson-logs/testlog.txt
```

> Meson has '--no-rebuild' option for these types of situations, could
> you try running "meson test --suite doc --no-rebuild" and see if that
> helps?

Confirmed that `--no-rebuild` option can avoid building C files, but I still
think it should be handled on the meson.build side.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2026-02-16 10:56:59 Re: Add a greedy join search algorithm to handle large join problems
Previous Message Soumya S Murali 2026-02-16 10:44:29 Re: [Patch]Add tab completion for DELETE ... USING