| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Chao Li' <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: Reject negative max_retention_duration values |
| Date: | 2026-06-09 14:44:56 |
| Message-ID: | OS9PR01MB12149836FBEA44F70CE3CBFD5F51D2@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Chao,
+1 the idea to reject the negative value.
```
@@ -4796,7 +4796,7 @@ should_stop_conflict_info_retention(RetainDeadTuplesData *rdt_data)
Assert(rdt_data->phase == RDT_WAIT_FOR_PUBLISHER_STATUS ||
rdt_data->phase == RDT_WAIT_FOR_LOCAL_FLUSH);
- if (!MySubscription->maxretention)
+ if (MySubscription->maxretention <= 0)
return false;
```
IIUC, the negative value can be rejected at CREATE/ALTER SUBSCRIPTION phase, right?
Why do we have to update even here? For the clarification purpose?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-06-09 15:15:31 | Re: Row pattern recognition |
| Previous Message | Marcos Pegoraro | 2026-06-09 14:33:04 | Re: Get rid of "Section.N.N.N" on DOCs |