| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: Follow-up review items for update_deleted |
| Date: | 2026-09-03 11:09:54 |
| Message-ID: | OS9PR01MB1214975F154718013E1B82D4AF5B62@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Hou,
Thanks for the patch. I reviewed 0001 and could not find critical issues.
Few comments;
01.
```
/* Remember the retained databases for the next cycle. */
current_dbids = lappend_oid(current_dbids, sub->dbid);
```
list_append_unique_oid() is usable here.
02. init_conflict_slot_xmin()
Not sure the function name is good because it can be called many times.
How about: reset_conflict_slot_xmin_to_safe_horizon()? Code comment should also
be updated.
03.
```
/* Write this slot to disk */
ReplicationSlotMarkDirty();
ReplicationSlotSave();
```
IIUC they are needed only if the slot is updated.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chee Wooson | 2026-09-03 11:26:25 | [PATCH v2] Avoid carrying self lock-only xmax to updated tuple |
| Previous Message | Zsolt Parragi | 2026-09-03 11:06:42 | Re: Offline data checksum changes can cause incorrect checksum state on standbys |