| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Ayush Tiwari' <ayushtiwari(dot)slg01(at)gmail(dot)com>, ♂π≌26218 <1991230470(at)qq(dot)com> |
| Cc: | pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Subject: | RE: START_REPLICATION silently truncates an overlong LSN component |
| Date: | 2026-09-11 02:35:22 |
| Message-ID: | OS9PR01MB1214972D4AF13C0B23FB2129EF5BE2@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Dear Ayush,
> It seems we should add it here to, attached patch does that.
> [Added a TAP test in patch, but I dont think it needs to be committed]
LGTM. I also think the test is not needed.
> I wonder if we should make the same change in libpqwalreceiver too.
I feel it should be, see attached. It could be combined with your patch.
I grepped the source with the keyword "scanf\(.*%X/%08X", and I could
not find other places where pg_parse_lsn() is usable as-is.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-pg_paser_lsn-in-libpqwalreceiver.patch | application/octet-stream | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Richard Guo | 2026-09-11 01:03:24 | Re: BUG #19633: Unexpected results of IN (subquery) with a non-deterministic collation |