| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tomas Vondra <tomas(at)vondra(dot)me>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, wenhui qiu <qiuwenhuifx(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Parallel Apply |
| Date: | 2026-04-27 10:44:19 |
| Message-ID: | OS9PR01MB1214966C529E3F118FD55F55FF5362@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
> +1 for the Option-2 as it simplifies the handling in patch as compared
> to others.
OK, let's proceed with the option.
> Apart from that,
> +/*
> + * Worker internal message types
> + *
> + * This type of messages would be generated by leader apply worker and sent to
> + * the parallel apply worker.
> + */
> +typedef enum WorkerInternalMsgType
> +{
> + WORKER_INTERNAL_MSG_DEPENDENCY = 'd',
> + WORKER_INTERNAL_MSG_RELATION = 'i',
> +} WorkerInternalMsgType;
> +
>
> I think here INTERNAL makes the purpose unclear whereas we know that
> these will always be used to communicate wth parallel apply workers.
> So, how about one of following options:
>
> typedef enum PAWorkerMsgType
> {
> PA_MSG_XACT_DEPENDENCY = 'd',
> PA_MSG_RELMAP = 'i',
> } PAWorkerMsgType;
Since either of them were OK for me, the shorter one is now used.
The latest patch is usable in [1].
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2026-04-27 10:57:52 | RE: Parallel Apply |
| Previous Message | Hayato Kuroda (Fujitsu) | 2026-04-27 10:42:55 | RE: Parallel Apply |