| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Gyan Sreejith <gyan(dot)sreejith(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | RE: [Proposal] Adding Log File Capability to pg_createsubscriber |
| Date: | 2026-03-18 13:44:37 |
| Message-ID: | OS9PR01MB1214902CC518A8102333FA88DF54EA@OS9PR01MB12149.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Amit,
>
> This looks odd to me. I think it would be better to encapsulate this
> in one function (something like we have in pg_log_v) and then based on
> log level, do required handling.
>
Based on the suggestion, I updated patches. Please see attached series.
v11-0001 replaces existing pg_log_xxx families to new reporting function
pg_createsub_log(). Now only pg_fatal is overwritten, which is same as pg_uprade.
v11-0002 is the rebased version of v10. Nothing new, but codes are adjusted based
on 0001.
v11-0003 contains changes from me [1]. 0002 and 0003 can be combined if it's OK.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-pg_createsubscriber-use-own-reporting-functions.patch | application/octet-stream | 55.0 KB |
| v11-0002-Add-a-new-argument-l-logdir-to-pg_createsubscrib.patch | application/octet-stream | 14.4 KB |
| v11-0003-Address-comments-from-Hayato-Kuroda.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-03-18 13:48:41 | Re: Read-only connection mode for AI workflows. |
| Previous Message | getiancheng | 2026-03-18 13:41:45 | Re: Release postmaster working memory context in slotsync worker |