| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Chao Li' <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Jiří Kavalík <jiri(dot)kavalik(at)comgate(dot)cz>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Streaming decoding fails with "unexpected table_index_fetch_tuple call during logical decoding" when a relation has a TOASTed conbin (follow-up to BUG #18641) |
| Date: | 2026-10-29 04:52:00 |
| Message-ID: | OS7PR01MB18317F6B0FE9F5F380885F60FF56E2@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi Chao,
> I agree with the solution. However, I have a minor concern about the naming.
> BeginSystemTableScan() and EndSystemTableScan() sound like functions that
> actually start and end system table scans, whereas they only track sysscan_depth.
> How about renaming them to TrackSystemTableScanStart() and
> TrackSystemTableScanEnd() to better reflect their purpose?
+1, PSA new version.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| nocfbot-v6-PG14-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 8.6 KB |
| nocfbot-v6-PG15-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 8.6 KB |
| nocfbot-v6-PG16-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 8.5 KB |
| nocfbot-v6-PG17-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 8.6 KB |
| nocfbot-v6-PG18-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 9.1 KB |
| nocfbot-v6-PG19-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 7.3 KB |
| v6-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 7.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Narayanan Venkateswaran | 2026-10-29 06:41:05 | Re: BUG #19800: Wrong results: self-join elimination drops an ORDER BY sort key with GROUPING SETS / CUBE / ROLLUP |
| Previous Message | David Rowley | 2026-10-29 03:23:22 | Re: BUG #19803: Assertion "!parallel_aware || pathnode->path.parallel_safe" in create_append_path |