RE: Fix apply worker crash when subscriber table has only a deferrable primary key

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Fix apply worker crash when subscriber table has only a deferrable primary key
Date: 2026-09-30 09:17:38
Message-ID: OS7PR01MB18317E6204C1275E261DEB077F58B2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amit,

> The caller of RelationFindDeletedTupleInfoSeq() already has
> information localindexoid/idxisreplident, why can't we use those
> values instead of computing the same information again? I am afraid
> that computing such an information again could lead to symptoms what
> we fixed in the recent commit
> ad36e3608c8cb6f0848737ec81e548d4d3a0af3c.

Your point meant not to get the info from the relcache because it can be
invalidated by the concurrent DDLs, right? I think it's possible, but the
additional computation might be needed since bitmapset for key columns are not
cached on the relmap now. Attached top-up patch implemented the idea, can you
see it's same as your expectation?
Test code just showed my understanding, not intended to be included for now.

> I suggest let's first fix this one and then we can discuss your other patch.

Yeah, it's related with PG19 issue thus it has higher priority.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
vatop-v3-0001-Don-t-use-RelationGetIndexAttrBitmap.patch application/octet-stream 9.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2026-09-30 09:29:03 Re: Direct TOAST v2, faster, smaller and no migration needed
Previous Message Hannu Krosing 2026-09-30 09:15:08 Re: Direct TOAST v2, faster, smaller and no migration needed