| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Bingshuai Li' <lucian1412(at)outlook(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, "alvherre(at)kurilemu(dot)de" <alvherre(at)kurilemu(dot)de>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "mark(dot)dilger(at)enterprisedb(dot)com" <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com>, "a(dot)kozhemyakin(at)postgrespro(dot)ru" <a(dot)kozhemyakin(at)postgrespro(dot)ru> |
| Subject: | RE: Bug in logical decoding with DDL and subtransactions |
| Date: | 2026-10-05 10:13:03 |
| Message-ID: | OS7PR01MB18317AFD6A46C4B4A7C4A461EF5962@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for updating the patch.
My idea was to call the cleanup function only once. A cleanup function can accept
a list of sub transactions, and checks them while iterating the tuplecids of the
top transaction. Per my understanding we can use the binary search because the list
of sub transactions are sorted by the logical XID. Attached .txt implements the idea.
> For cfbot, reattaching v5 for master only. The REL_* attachments in my
> previous message are alternative backpatch versions, not a patch
> series. Cfbot applied the master patch successfully, then tried to
> apply the REL_14_STABLE version on top of it and reported conflicts.
TIPS: attaching .txt is a known workaround [1].
[1]: https://wiki.postgresql.org/wiki/Cfbot
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| atop_v5_kuroda.txt | text/plain | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-10-05 10:18:04 | Re: [PATCH] Fix vacuum_delay_point happening inside lock |
| Previous Message | Alexandre Felipe | 2026-10-05 09:59:16 | Re: WAL segment file descriptor leak on read errors can PANIC the server |