| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Bharath Rupireddy' <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Jingtang Zhang <mrdrivingduck(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | RE: Use WALReadFromBuffers in more places |
| Date: | 2026-10-27 11:40:25 |
| Message-ID: | OS7PR01MB183178A50F430AC19E5CEDC60F5602@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Recently I came up with the similar idea and finally found the thread,
started to learn...
I found your performance looks very nice. IIUC, the performance can be decreased
if the wal_buffer is not enough large and walsenders always miss the cache, right?
Can we confirm when it can happen?
Regarding the code, state->seg.ws_tli cannot be updated if logical_read_xlog_page()
bypasses the actual WAL read. It seems to break the callback rule determined
in xlogheader.h:
```
* The callback shall set ->seg.ws_tli to the TLI of the file the page was
* read from.
*/
XLogPageReadCB page_read;
```
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Burd | 2026-10-27 11:47:13 | Re: ZSTD TOAST compression, and an extensible compression method encoding |
| Previous Message | Etsuro Fujita | 2026-10-27 11:34:50 | Re: Asynchronous MergeAppend |