| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Zhijie Hou' <houzhijie22(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, saurabh singh <saurabh(dot)singh214(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com> |
| Subject: | RE: Proposal: Conflict log history table for Logical Replication |
| Date: | 2026-11-20 11:08:25 |
| Message-ID: | OS7PR01MB18317875C8AFF7481B33957F3F5782@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
> Here is the V96 version which:
Thanks for updating the patch. I reviewed v96-0001 and LGTM. I have one comment
for codes in HEAD, let me share just in case.
```
/* Create conflict log table. */
relid = heap_create_with_catalog(relname,
PG_CONFLICT_NAMESPACE,
0, /* tablespace */
...
```
In create_conflict_log_table() the tablespace is specified as 0, it bypasses a GUC
default_tablespace. Is it intentional? The parameter can be resolved by
GetDefaultTablespace().
Even if we retain the behavior, it can be InvalidOid
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-11-20 11:13:47 | Re: [PATCH] pg_upgrade: add --initdb option to create the new cluster automatically |
| Previous Message | Fujii Masao | 2026-11-20 10:44:39 | Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed |