| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Zhijie Hou' <houzhijie22(at)gmail(dot)com> |
| Cc: | "jiri(dot)kavalik(at)comgate(dot)cz" <jiri(dot)kavalik(at)comgate(dot)cz>, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Streaming decoding fails with "unexpected table_index_fetch_tuple call during logical decoding" when a relation has a TOASTed conbin (follow-up to BUG #18641) |
| Date: | 2026-10-08 02:36:48 |
| Message-ID: | OS7PR01MB183176541B4DF2EFBB09AFFB1F5932@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Dear Hou,
Thanks for the review!
> I think using a counter to fix this is OK. But I'm wondering whether it's
> necessary to keep both the boolean and the counter, could we merge them into
> a
> single parameter to simplify things?
Actually it's intentional because the initially attached patch was for PG18.
bsysscan was exported and functions in tableam.h referred it. I did not want to
modify the header as much as possible thus they were retained.
For HEAD, yes, the boolean can be removed from everywhere, see attached.
I will create patched for back branches when they are stabilized.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| Attachment | Content-Type | Size |
|---|---|---|
| v2-HEAD-0001-Track-the-depth-of-scans-of-system-tables.patch | application/octet-stream | 10.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jiří Kavalík | 2026-10-08 05:35:07 | Re: Streaming decoding fails with "unexpected table_index_fetch_tuple call during logical decoding" when a relation has a TOASTed conbin (follow-up to BUG #18641) |
| Previous Message | shihao zhong | 2026-10-08 02:30:48 | Re: BUG #19735: `jsonb_object_agg_unique_strict` drops a JSONB `null` value as if it were SQL NULL |