RE: Streaming decoding fails with "unexpected table_index_fetch_tuple call during logical decoding" when a relation has a TOASTed conbin (follow-up to BUG #18641)

Hi Shlok,

Thanks for the review!

> 1. For all patches: Most of the comments for function in the file
> 'xact.c' is like of format:
> /*
> * Function name
> *
> * Function Description
> */
> Maybe we should follow the same for the functions added by these patches?

I do not have strong opinions for it, but added accordingly.

> 2. For patches for PG14 to PG18: In logical.c we can remove:
> +#include "access/genam.h"
> #include "access/xact.h"
>
> In logical.c we only introduced "ResetSystemTableScanState();" and
> this function which was declared 'access/xact.h'
> logical.c already includes access/xact.h

Fixed. It was included because functions are initially declared in genam.h.

> 3. For patches for PG 18 and PG 17: I noticed a unrelated line deletion change:
> #include "utils/snapmgr.h"
>
> -
> /* ----------------------------------------------------------------
>
> Was it intentional?

No, removed.

> 4. For patches for PG 14 and PG 15:
> + ALTER TABLE nested_sys_scan_test ALTER COLUMN checked_value set
> storage external;
> I think we should capitalize 'set storage external;'

+1. Fixed.

PSA new patch set.

Best regards,
Hayato Kuroda
FUJITSU LIMITED