RE: Fix apply worker crash when subscriber table has only a deferrable primary key

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Nisha Moond' <nisha(dot)moond412(at)gmail(dot)com>
Cc: Zhijie Hou <houzhijie22(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: RE: Fix apply worker crash when subscriber table has only a deferrable primary key
Date: 2026-10-05 05:53:45
Message-ID: OS7PR01MB183175A0C8C0710245FE1E135F5962@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Nisha,

> Thanks for pushing the patch.
> Here is the rebased v4 patch for the remaining issue in this thread.

Thanks for updating the patch!

While reading the patch again, I came up with another idea to use already-found
local index. I.e., move logicalrep_rel_mark_updatable() after the
FindLogicalRepLocalIndex() then refer entry->idxisreplident and entry->localindexoid.
It may change codes bit more but we can use the single source of truth.

How do you feel?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-10-05 06:06:54 Re: tuplesort_putdatum() does not account for tuple memory
Previous Message Michael Paquier 2026-10-05 05:52:41 Re: WAL segment file descriptor leak on read errors can PANIC the server