RE: Avoid resetting subscription two_phase state to pending when already enabled

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Zhijie Hou' <houzhijie22(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>
Subject: RE: Avoid resetting subscription two_phase state to pending when already enabled
Date: 2026-10-29 07:56:13
Message-ID: OS7PR01MB183173F839BDB41302F3054DFF56E2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Right. This is the same as all (or most) subscription options and even
> other object options like publication options have the same behavior,
> since we don't compare the new value with the old one in most cases. So
> I think that's an independent topic.

Make sense. I checked the v2 patch and LGTM.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2026-10-29 08:11:26 Re: pgsql: Set HEAP_XMAX_INVALID for tuples updated by aborted subtransacti
Previous Message Zhijie Hou 2026-10-29 07:37:15 Re: Avoid resetting subscription two_phase state to pending when already enabled