RE: Patch for migration of the pg_commit_ts directory

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Ajin Cherian' <itsajin(at)gmail(dot)com>
Cc: Sergey <ls7777(at)yandex(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "orlovmg(at)gmail(dot)com" <orlovmg(at)gmail(dot)com>, "amit(dot)kapila16(at)gmail(dot)com" <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Subject: RE: Patch for migration of the pg_commit_ts directory
Date: 2026-11-13 09:04:21
Message-ID: OS7PR01MB18317306A235AB87889884A91F57F2@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Ajin,

Thanks for the review, PSA new version.

> 2. 0003: There is already a separate patch that preserves replication
> origins during upgrade [1], so I suggest removing 0003 from this patch
> set.

I just retained just in case, dropped now.

> 3. 0001/0002: I agree with Maxim that 0001 shouldn't be committed
> without 0002 (or without origins being preserved). Otherwise the wider
> commit_ts range turns stale origin IDs into false
> update/delete_origin_differs conflicts, as Sawada-san showed.

Hmm, I'm still unclear the situation. Can you share me the workload?

> 4. 0002: The option name --pg-commit-ts and the help text "copy
> pg_commit_ts directory" describe the implementation rather than the
> behaviour. How about something like --preserve-commit-timestamps?
> Also, the help line is placed between -V and --clone, which breaks the
> alphabetical order of the long options.

Updated. how do you feel?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
v17-0001-pg_upgrade-Preserve-commit-timestamps-across-upg.patch application/octet-stream 11.1 KB
v17-0002-pg_upgrade-Add-option-to-preserve-commit-timesta.patch application/octet-stream 5.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexandre Felipe 2026-11-13 09:13:21 Re: pg_regress: schedule multi-line test groups
Previous Message Hayato Kuroda (Fujitsu) 2026-11-13 09:03:28 RE: Patch for migration of the pg_commit_ts directory