RE: START_REPLICATION silently truncates an overlong LSN component

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'Fujii Masao' <masao(dot)fujii(at)gmail(dot)com>
Cc: Jan Nidzwetzki <jan(at)planetscale(dot)com>, Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, ♂π≌26218 <1991230470(at)qq(dot)com>, pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: RE: START_REPLICATION silently truncates an overlong LSN component
Date: 2026-10-20 11:29:38
Message-ID: OS7PR01MB183171391E7DA9DB9DBDEF419F5672@OS7PR01MB18317.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Hi Fujii-san,

Thanks for the review.

> I think we can omit the test in 0003. We made the similar change in pg_rewind
> in f31d6fbc31d without adding a test, and pg_parse_lsn() is already covered
> through other callers.

+1.

> > I also checked the source, and found that read_backup_label() parses
> the %X/%08X
> > in fscanf(). Can it be also replaced?
>
> I think that's possible.

OK, PSA 0004. We can reduce the magic number from 0004 if we export
MAXPG_LSNLEN, but not done yet.

All patches are attached to run CI.
0001 and 0002 are not changed, tests were removed from 0003.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
v3-0001-Use-pg_parse_lsn-for-START_REPLICATION.patch application/octet-stream 2.5 KB
v3-0002-Use-pg_paser_lsn-in-libpqwalreceiver.patch application/octet-stream 1.4 KB
v3-0003-Use-pg_parse_lsn-for-timeline-history-switchpoint.patch application/octet-stream 3.1 KB
v3-0004-Use-pg_parse_lsn-for-reading-backup-label.patch application/octet-stream 3.0 KB

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Staroverov Ilja 2026-10-20 13:20:41 Re: BUG #19644: byteaout, float8out and float4out are marked IMMUTABLE but depend on GUCs
Previous Message Fujii Masao 2026-10-20 09:31:18 Re: START_REPLICATION silently truncates an overlong LSN component