| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com>, Sergei Patiakin <sergei(dot)patiakin(at)enterprisedb(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "msawada(at)postgresql(dot)org" <msawada(at)postgresql(dot)org> |
| Subject: | RE: Session in aborted transaction misses effective_wal_level change |
| Date: | 2026-10-01 06:28:38 |
| Message-ID: | OS7PR01MB183171352C8034F7415A54CC5F58A2@OS7PR01MB18317.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san, Serigei,
Good catch, I have also been seeing and considering the test, but Sawada-san is faster.
> The fix looks good to me. We need to check and update XLogLogicalInfo
> in every place where we reset the top-level transaction id.
>
> I've updated the patch with the regression tests. Please review it.
Confirmed the test fails on HEAD and pass after the patch.
There might be idea to put the function after the "nParallelCurrentXids = 0;"
even in the CommitTransaction() and PrepareTransaction(), which is same as
CleanupTransaction(). But any places are OK for me.
LGTM.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nisha Moond | 2026-10-01 06:39:25 | Re: Fix apply worker crash when subscriber table has only a deferrable primary key |
| Previous Message | Narayanan Venkateswaran | 2026-10-01 06:12:00 | Re: postgres_fdw: Fix costing of remote sorts without remote estimates |