| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Ajin Cherian' <itsajin(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | RE: 024_add_drop_pub.pl might fail due to deadlock |
| Date: | 2025-07-29 01:53:00 |
| Message-ID: | OS7PR01MB149682E5CAA567A7798BC6BA9F525A@OS7PR01MB14968.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Ajin,
> Thanks for your review Kuroda-san, I have changed the logic to not use
> already_locked and instead check if the locks are taken inside
> UpdateSubscriptionRelState itself. I've tested this and this works
> fine. If this logic is acceptable to the reviewers I can update the
> other patches also in a similar way.
Thanks for updates.
However, I found that functions like LockHeldByMe(), CheckRelationOidLockedByMe()
and LWLockHeldByMe() have been used only for the debug build. Functions like
ProcArraySetReplicationSlotXmin() and MarkAsPrepared() can remove the flag from
the argument but they are retained till now.
Based on that, I suggest adding new argument (or add new Ex function for bank branches)
and do the assertion check when the assertion is enabled in this build. Thought?
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2025-07-29 01:56:28 | Re: Improve error reporting in 027_stream_regress test |
| Previous Message | Michael Paquier | 2025-07-29 01:46:16 | Re: Improve error reporting in 027_stream_regress test |